GitHub user ejwhite922 opened a pull request:

    https://github.com/apache/incubator-rya/pull/285

    RYA-469 Added tests for Rya Streams join iterator bug using LUBM data.

    ## Description
    Joins were not working in Rya Streams.  The KeyValueJoinStateStore needed 
to have a queryId associated with each row in RocksDB.  Also, the range search 
that returned the RocksDB iterator needed to mark where the join variables 
ended so the results would not include characters that came after the start and 
end range markers (i.e. a range search from "urn:Student9[0x00]" to 
"urn:Student9[0xFF]" would incorrectly include 
"urn:Student95,[remainingBindingResults]" when we only wanted rows for 
"urn:Student9").
    
    ### Tests
    LUBM data and queries were added for testing.
    Unit Tests
    
    ### Links
    [Jira](https://issues.apache.org/jira/browse/RYA-469)
    
    ### Checklist
    - [ ] Code Review
    - [ ] Squash Commits
    
    #### People To Review
    @isper3at 
    @kchilton2 
    @pujav65 
    @meiercaleb 
    @amihalik 
    @DLotts
    @jessehatfield 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ejwhite922/incubator-rya 
RYA-469_RyaStreamsJoinIteratorBug

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rya/pull/285.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #285
    
----
commit a6c9bf8604705ece21d68543cd7bcc1ea252204a
Author: eric.white <eric.white@...>
Date:   2018-03-29T19:32:56Z

    RYA-469 Added tests for Rya Streams join iterator bug using LUBM data.

----


---

Reply via email to