Github user kchilton2 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/285#discussion_r178385888
  
    --- Diff: 
extras/rya.streams/kafka/src/main/java/org/apache/rya/streams/kafka/processors/join/KeyValueJoinStateStore.java
 ---
    @@ -77,30 +77,39 @@
         /**
          * This is the maximum value of a UTF-8 character.
          */
    -    private static final String END_RANGE_SUFFIX = new String(new byte[] { 
(byte) 0XFF }, Charsets.UTF_8);
    +    private static final String END_RANGE_SUFFIX = new String(new byte[] { 
(byte) 0xFF }, Charsets.UTF_8);
    +
    +    /**
    +     * Indicates where the end of the join variables occurs.
    +     */
    +    private static final String JOIN_VAR_END_MARKER = new 
String("~!^~".getBytes(Charsets.UTF_8), Charsets.UTF_8);
    --- End diff --
    
    I'm not sure that the marker should be in the visually renderable byte 
ranges since, while very unlikely, they could legitimately appear in the data 
that is being indexed.


---

Reply via email to