[ https://issues.apache.org/jira/browse/RYA-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16615427#comment-16615427 ]
ASF GitHub Bot commented on RYA-135: ------------------------------------ Github user isper3at commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/300#discussion_r217849654 --- Diff: extras/indexing/src/main/java/org/apache/rya/indexing/mongodb/AbstractMongoIndexer.java --- @@ -73,12 +72,12 @@ protected T storageStrategy; private MongoDbBatchWriter<DBObject> mongoDbBatchWriter; + protected String collectionName; --- End diff -- getCollectionName() would build the collection name with the collection suffix and rya prefix > Confusing configuration: CONF_TBL_PREFIX versus MONGO_COLLECTION_PREFIX > versus RyaInstance > ------------------------------------------------------------------------------------------- > > Key: RYA-135 > URL: https://issues.apache.org/jira/browse/RYA-135 > Project: Rya > Issue Type: Improvement > Components: sail > Reporter: David W. Lotts > Assignee: Andrew Smith > Priority: Minor > > These THREE constants [#1] [#2] [#3] are somewhat redundant. They are the > the same as the Rya Instance in most cases. For MongoDB, the table > prefix[#2] may be used incorrectly instead of the collection prefix[#1]. > They should probably be melded into one config key and method and be called > the rya instance. The RyaDetails has this concept. There is a > ConfigUtil.getTablePrefix() and TablePrefixLayoutStrategy.getTablePrefix() > that should be refactored as part of this. > Some have suggested that the collection prefix is not needed at all since it > is scoped inside a single Mongo Database which contains only one rya instance. > {anchor:1}1 {code} conf.set(MongoDBRdfConfiguration.MONGO_COLLECTION_PREFIX, > "rya_");{code} > {anchor:2}2 {code}conf.set(RdfCloudTripleStoreConfiguration.CONF_TBL_PREFIX, > "rya_");{code} > {anchor:3}3 {code}TablePrefixLayoutStrategy.tablePrefix = > RdfCloudTripleStoreConstants.TBL_PRFX_DEF; // = "rya_";{code} > Some unit tests set them as different values. > Look at > extras/indexing/src/main/java/mvm/rya/sail/config/RyaSailFactory.java around > line 73 for a good example of the confusion. Look for this comment: > // XXX Should(?) be MongoDBRdfConfiguration.MONGO_COLLECTION_PREFIX inside > the if below. > One more redundant field: TablePrefixLayoutStrategy.tablePrefix See RYA-138 > It is defaults to "rya_" but has a getter and setter. > {code} > TablePrefixLayoutStrategy implements TableLayoutStrategy{ > private String tablePrefix = RdfCloudTripleStoreConstants.TBL_PRFX_DEF; > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)