funky-eyes commented on code in PR #6629:
URL: https://github.com/apache/incubator-seata/pull/6629#discussion_r1685858845
##########
rm-datasource/src/main/java/org/apache/seata/rm/datasource/xa/ConnectionProxyXA.java:
##########
@@ -226,7 +226,12 @@ public synchronized void commit() throws SQLException {
long now = System.currentTimeMillis();
checkTimeout(now);
setPrepareTime(now);
- xaResource.prepare(xaBranchXid);
+ int prepare = xaResource.prepare(xaBranchXid);
+ if (prepare == XAResource.XA_RDONLY
+ && JdbcConstants.ORACLE.equals(resource.getDbType())) {
Review Comment:
The community meeting has agreed to this approach, and in addition, can you
test other databases to see if the corresponding prepare result codes are the
same? If so, we hope to remove the special handling of Oracle alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
