gongycn commented on code in PR #6629:
URL: https://github.com/apache/incubator-seata/pull/6629#discussion_r1695056017
##########
rm-datasource/src/main/java/org/apache/seata/rm/datasource/xa/ConnectionProxyXA.java:
##########
@@ -226,7 +226,12 @@ public synchronized void commit() throws SQLException {
long now = System.currentTimeMillis();
checkTimeout(now);
setPrepareTime(now);
- xaResource.prepare(xaBranchXid);
+ int prepare = xaResource.prepare(xaBranchXid);
+ if (prepare == XAResource.XA_RDONLY
+ && JdbcConstants.ORACLE.equals(resource.getDbType())) {
Review Comment:
Sure, purely speaking from MySQL and Oracle, the database type check can be
eliminated. I'll try PostgreSQL next, and over the weekend, I'll look for
resources to test MSSQL Server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
