funky-eyes commented on code in PR #6998:
URL: https://github.com/apache/incubator-seata/pull/6998#discussion_r1853160658
##########
core/src/main/java/org/apache/seata/core/rpc/netty/AbstractNettyRemoting.java:
##########
@@ -173,6 +175,12 @@ protected Object sendSync(Channel channel, RpcMessage
rpcMessage, long timeoutMi
LOGGER.warn("sendSync nothing, caused by null channel.");
return null;
}
+ if (MsgVersionHelper.versionNotSupport(channel, rpcMessage)) {
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug("Message sending will be skipped as the client
version does not support it,{}", rpcMessage);
+ }
+ return new VersionNotSupportMessage();
Review Comment:
看起来没有使用到它的地方，后续将有何作用？
It seems that it is not being used anywhere. What will its role be in the
future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
