Bughue commented on code in PR #6998:
URL: https://github.com/apache/incubator-seata/pull/6998#discussion_r1853166688
##########
core/src/main/java/org/apache/seata/core/rpc/netty/AbstractNettyRemoting.java:
##########
@@ -173,6 +175,12 @@ protected Object sendSync(Channel channel, RpcMessage
rpcMessage, long timeoutMi
LOGGER.warn("sendSync nothing, caused by null channel.");
return null;
}
+ if (MsgVersionHelper.versionNotSupport(channel, rpcMessage)) {
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug("Message sending will be skipped as the client
version does not support it,{}", rpcMessage);
+ }
+ return new VersionNotSupportMessage();
Review Comment:
> 看起来没有使用到它的地方，后续将有何作用？ It seems that it is not being used anywhere. What
will its role be in the future?
比如以后的版本里如果要sync发送某个全新的request类，旧版本无法识别，在remote通信这层会返回VersionNotSupportMessage，发送者判断到返回类型是这个后做忽略处理或者抛出异常
For example, if you want to send a sync to a new request class in a future
version that is not recognized by the old version, the versionNotSupportMessage
will be returned at the remote communication level, and the sender will either
ignore the return type or throw an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
