xjlgod commented on code in PR #741:
URL:
https://github.com/apache/incubator-seata-go/pull/741#discussion_r1894825859
##########
pkg/saga/statemachine/statelang/parser/statemachine_json_parser.go:
##########
@@ -22,10 +21,8 @@ func (stateMachineParser JSONStateMachineParser) GetType()
string {
return "JSON"
}
-func (stateMachineParser JSONStateMachineParser) Parse(content string)
(statelang.StateMachine, error) {
- var stateMachineJsonObject StateMachineJsonObject
-
- err := json.Unmarshal([]byte(content), &stateMachineJsonObject)
+func (stateMachineParser JSONStateMachineParser) Parse(configFilePath string)
(statelang.StateMachine, error) {
Review Comment:
Make interface and the impl has same param
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
