Re: [PR] [to-reply] feature: support saga multi type config [incubator-seata-go]

[via GitHub]

FinnTew commented on code in PR #741:
URL: 
https://github.com/apache/incubator-seata-go/pull/741#discussion_r1916882857


##########
pkg/saga/statemachine/statelang/parser/task_state_json_parser.go:
##########
@@ -242,7 +259,7 @@ func (s ServiceTaskStateParser) Parse(stateName string, 
stateMap map[string]inte
                return nil, err
        }
 
-       serviceName, err := s.GetString(stateName, stateMap, "serviceName")
+       serviceName, err := s.GetString(stateName, stateMap, "ServiceName")

Review Comment:
   During testing, I encountered errors, and upon investigation, I found that 
the key names in the three sets of test data in `testdata/statelang` were all 
"ServiceName" instead of "serviceName", as shown in the figure below. 
Therefore, I made the necessary modifications to parse the unit test.
   
![IMG_20250115_233630.jpg](https://github.com/user-attachments/assets/edb77411-fa20-482a-9ad7-5966f8d776e2)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org