slievrly commented on code in PR #7089:
URL: https://github.com/apache/incubator-seata/pull/7089#discussion_r1901689921
##########
discovery/seata-discovery-namingserver/src/main/java/org/apache/seata/discovery/registry/namingserver/NamingserverRegistryServiceImpl.java:
##########
@@ -148,9 +147,11 @@ static NamingserverRegistryServiceImpl getInstance() {
@Override
public void register(InetSocketAddress address) throws Exception {
- NetUtil.validAddress(address);
- Instance instance = Instance.getInstance();
- instance.setTransaction(new
Node.Endpoint(address.getAddress().getHostAddress(), address.getPort(),
"netty"));
+ register(Instance.getInstance());
Review Comment:
The IP address should be checked to ensure that it is not a loopback address.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
