slievrly commented on code in PR #7089:
URL: https://github.com/apache/incubator-seata/pull/7089#discussion_r1901694826
##########
core/src/main/java/org/apache/seata/core/rpc/netty/NettyServerBootstrap.java:
##########
@@ -170,9 +172,13 @@ public void initChannel(SocketChannel ch) {
try {
this.serverBootstrap.bind(port).sync();
LOGGER.info("Server started, service listen port: {}",
getListenPort());
- InetSocketAddress address = new
InetSocketAddress(XID.getIpAddress(), XID.getPort());
+ Instance instance = Instance.getInstance();
Review Comment:
I don't think it makes sense for `Instance` to be designed as a singleton.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
