slievrly commented on code in PR #24:
URL: 
https://github.com/apache/incubator-seata-k8s/pull/24#discussion_r1941521228


##########
deploy/seata-server-cluster.yaml:
##########
@@ -9,10 +9,10 @@ spec:
   image: seataio/seata-server:latest
   persistence:
     volumeReclaimPolicy: Delete
-  store:
-    resources:
-      requests:
-        storage: 5Gi
+    spec:

Review Comment:
   Thank you very much for your feedback. For this issue, I think it needs 
further modification. The semantics of spec.persistence.spec here is not clear. 
I hope to optimize the name of this attribute to make it have a more explicit 
meaning. Depending on the API specification, it is best to fix this issue by 
upgrading the CRD version.
   
![image](https://github.com/user-attachments/assets/74e37962-5a91-4376-b02a-5263c3ca9c0c)
   
https://github.com/apache/incubator-seata-k8s/blob/master/config/crd/bases/operator.seata.apache.org_seataservers.yaml#L153



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org

Reply via email to