slievrly commented on code in PR #24:
URL: 
https://github.com/apache/incubator-seata-k8s/pull/24#discussion_r1976217956


##########
config/crd/bases/operator.seata.apache.org_seataservers.yaml:
##########
@@ -441,6 +441,60 @@ spec:
               serviceName:
                 default: seata-server-cluster
                 type: string
+              store:
+                description: Store defines the storage configuration for 
SeataServer
+                properties:
+                  resources:
+                    description: ResourceRequirements describes the compute 
resource
+                      requirements.
+                    properties:
+                      claims:
+                        description: "Claims lists the names of resources, 
defined
+                          in spec.resourceClaims, that are used by this 
container.
+                          \n This is an alpha field and requires enabling the 
DynamicResourceAllocation
+                          feature gate. \n This field is immutable. It can 
only be
+                          set for containers."
+                        items:
+                          description: ResourceClaim references one entry in 
PodSpec.ResourceClaims.
+                          properties:
+                            name:
+                              description: Name must match the name of one 
entry in
+                                pod.spec.resourceClaims of the Pod where this 
field
+                                is used. It makes that resource available 
inside a
+                                container.
+                              type: string
+                          required:
+                          - name
+                          type: object
+                        type: array
+                        x-kubernetes-list-map-keys:
+                        - name
+                        x-kubernetes-list-type: map
+                      limits:

Review Comment:
   For persistent storage, limits are generally not needed because dynamic 
changes cannot be made during runtime.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org

Reply via email to