funky-eyes commented on code in PR #7157:
URL: https://github.com/apache/incubator-seata/pull/7157#discussion_r1950397743
##########
namingserver/src/main/java/org/apache/seata/namingserver/controller/NamingController.java:
##########
@@ -96,10 +100,8 @@ public MetaResponse discovery(@RequestParam String vGroup,
@RequestParam String
}
@PostMapping("/addGroup")
- public Result<String> addGroup(@RequestParam String namespace,
- @RequestParam String clusterName,
- @RequestParam String unitName,
- @RequestParam String vGroup) {
+ public Result<String> addGroup(@RequestParam String namespace,
@RequestParam String clusterName, String unitName,
+ @RequestParam String vGroup) {
Review Comment:
The unitname is only used for the group in Seata's Raft mode. It is not
required for other storage modes, so it is not necessary to provide it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
