funky-eyes commented on code in PR #7157:
URL: https://github.com/apache/incubator-seata/pull/7157#discussion_r1950398997
##########
namingserver/src/main/java/org/apache/seata/namingserver/controller/NamingController.java:
##########
@@ -113,14 +115,18 @@ public Result<String> changeGroup(@RequestParam String
namespace,
@RequestParam String clusterName,
@RequestParam String unitName,
@RequestParam String vGroup) {
-
Result<String> addGroupResult = namingManager.changeGroup(namespace,
vGroup, clusterName, unitName);
if (!addGroupResult.isSuccess()) {
return addGroupResult;
}
return new Result<>("200", "change vGroup " + vGroup + "to cluster " +
clusterName + " successfully!");
Review Comment:
Yes, but it is not within the scope of responsibility of the pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
