xingfudeshi commented on code in PR #7223:
URL: https://github.com/apache/incubator-seata/pull/7223#discussion_r2006873393


##########
pom.xml:
##########
@@ -289,6 +289,78 @@
                 </plugins>
             </build>
         </profile>
+
+        <!-- profile: spotless -->
+        <profile>
+            <id>jdk9-jdk11-spotless</id>
+            <activation>
+                <jdk>[1.8, 11)</jdk>
+            </activation>
+            <properties>
+                <palantirJavaFormat.version>1.1.0</palantirJavaFormat.version>
+            </properties>
+        </profile>
+
+        <profile>
+            <id>jdk11-jdk21-spotless</id>
+            <activation>
+                <jdk>[11, 21)</jdk>
+            </activation>
+            <properties>
+                <palantirJavaFormat.version>2.28.0</palantirJavaFormat.version>
+            </properties>
+        </profile>
+
+        <profile>
+            <id>jdk21-spotless</id>
+            <activation>
+                <jdk>[21,)</jdk>
+            </activation>
+            <properties>
+                <palantirJavaFormat.version>2.39.0</palantirJavaFormat.version>
+            </properties>
+        </profile>
+        <profile>
+            <id>java11+</id>
+            <activation>
+                <jdk>[11,)</jdk>
+            </activation>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>com.diffplug.spotless</groupId>
+                        <artifactId>spotless-maven-plugin</artifactId>
+                        <version>${spotless-maven-plugin.version}</version>
+                        <configuration>
+                            <java>
+                                <excludes>
+                                    <exclude>**/script/**</exclude>
+                                    <exclude>**/generated/**</exclude>
+                                    
<exclude>**/antlr/mysql/parser/*.*</exclude>
+                                    <exclude>**/antlr/mysql/antlr/*.*</exclude>
+                                    
<exclude>**/antlr/mysql/stream/ANTLRNoCaseStringStream.java</exclude>
+                                </excludes>
+                                <ratchetFrom>HEAD</ratchetFrom>

Review Comment:
   > @funky-eyes
   > 
   > Currently, our baseline is set to `HEAD`, which means that only files 
changed since the last commit are considered. This creates a potential issue: 
if code with incorrect formatting gets committed, `checkstyle` will catch it, 
but `Spotless` won’t apply its fixes, and we lose the intended benefit.
   > 
   > To address this, we tried switching the baseline from HEAD to 
`origin/2.x`. However, the branch wasn’t recognized. 🥹
   > 
   > What do you think?
   
   Hi, I pulled your code and followed the steps. Seems to work!
   ```
   1. git checkout feature/apply-spotless
   2. Change the value of ratchetFrom from HEAD to feature/apply-spotless
   3. Add some spaces in the method of Java class, like this
   ```
   <img width="660" alt="image" 
src="https://github.com/user-attachments/assets/bc195e49-b489-48b2-9e21-73f261486dd1";
 /> 
   
   ```
   4. mvn spotless:check
   5. Then I got the outputs like this
   ```
   <img width="1206" alt="image" 
src="https://github.com/user-attachments/assets/ad93a013-878f-4455-939e-b83e8f494c6b";
 />
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org

Reply via email to