funky-eyes commented on code in PR #7223:
URL: https://github.com/apache/incubator-seata/pull/7223#discussion_r2020508462
##########
pom.xml:
##########
@@ -289,6 +289,78 @@
</plugins>
</build>
</profile>
+
+ <!-- profile: spotless -->
+ <profile>
+ <id>jdk9-jdk11-spotless</id>
+ <activation>
+ <jdk>[1.8, 11)</jdk>
+ </activation>
+ <properties>
+ <palantirJavaFormat.version>1.1.0</palantirJavaFormat.version>
+ </properties>
+ </profile>
+
+ <profile>
+ <id>jdk11-jdk21-spotless</id>
+ <activation>
+ <jdk>[11, 21)</jdk>
+ </activation>
+ <properties>
+ <palantirJavaFormat.version>2.28.0</palantirJavaFormat.version>
+ </properties>
+ </profile>
+
+ <profile>
+ <id>jdk21-spotless</id>
+ <activation>
+ <jdk>[21,)</jdk>
+ </activation>
+ <properties>
+ <palantirJavaFormat.version>2.39.0</palantirJavaFormat.version>
+ </properties>
+ </profile>
+ <profile>
+ <id>java11+</id>
+ <activation>
+ <jdk>[11,)</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.diffplug.spotless</groupId>
+ <artifactId>spotless-maven-plugin</artifactId>
+ <version>${spotless-maven-plugin.version}</version>
+ <configuration>
+ <java>
+ <excludes>
+ <exclude>**/script/**</exclude>
+ <exclude>**/generated/**</exclude>
+
<exclude>**/antlr/mysql/parser/*.*</exclude>
+ <exclude>**/antlr/mysql/antlr/*.*</exclude>
+
<exclude>**/antlr/mysql/stream/ANTLRNoCaseStringStream.java</exclude>
+ </excludes>
+ <ratchetFrom>HEAD</ratchetFrom>
Review Comment:
I noticed that after setting it to 2.x, the number of changed files is quite
large, unless we are willing to accept changes to all files. Otherwise, I think
we can initially set it to HEAD, merge this PR, and then create an issue to
discuss the remaining problems.
@slievrly What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
