YongGoose commented on code in PR #7223: URL: https://github.com/apache/incubator-seata/pull/7223#discussion_r2036742095
########## pom.xml: ########## @@ -289,6 +289,78 @@ </plugins> </build> </profile> + + <!-- profile: spotless --> + <profile> + <id>jdk9-jdk11-spotless</id> + <activation> + <jdk>[1.8, 11)</jdk> + </activation> + <properties> + <palantirJavaFormat.version>1.1.0</palantirJavaFormat.version> + </properties> + </profile> + + <profile> + <id>jdk11-jdk21-spotless</id> + <activation> + <jdk>[11, 21)</jdk> + </activation> + <properties> + <palantirJavaFormat.version>2.28.0</palantirJavaFormat.version> + </properties> + </profile> + + <profile> + <id>jdk21-spotless</id> + <activation> + <jdk>[21,)</jdk> + </activation> + <properties> + <palantirJavaFormat.version>2.39.0</palantirJavaFormat.version> + </properties> + </profile> + <profile> + <id>java11+</id> + <activation> + <jdk>[11,)</jdk> + </activation> + <build> + <plugins> + <plugin> + <groupId>com.diffplug.spotless</groupId> + <artifactId>spotless-maven-plugin</artifactId> + <version>${spotless-maven-plugin.version}</version> + <configuration> + <java> + <excludes> + <exclude>**/script/**</exclude> + <exclude>**/generated/**</exclude> + <exclude>**/antlr/mysql/parser/*.*</exclude> + <exclude>**/antlr/mysql/antlr/*.*</exclude> + <exclude>**/antlr/mysql/stream/ANTLRNoCaseStringStream.java</exclude> + </excludes> + <ratchetFrom>HEAD</ratchetFrom> + <palantirJavaFormat> + <version>${palantirJavaFormat.version}</version> + </palantirJavaFormat> + <removeUnusedImports/> + <trimTrailingWhitespace/> + <endWithNewline/> + </java> + </configuration> + <executions> + <execution> + <goals> Review Comment: This doesn't work in GitHub Actions. Automatically formatting and committing changes seems more suitable for a `git hook`, which would require users to modify their local `.git` folder. For now, in this PR, I’ve applied `Spotless`. I’m planning to explore additional improvements in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org