funky-eyes commented on PR #7337: URL: https://github.com/apache/incubator-seata/pull/7337#issuecomment-2870979019
> > This design is to callback the ChannelEventListener registered by TM and RM, rather than adding a listener after channel.write(), right? > > Yes, that's correct. > > It is implemented in a way that calls back the `ChannelEventListener` registered in advance by TM and RM, so that user-defined actions can be performed when the channel event is detected. I think this design is good, but since this functionality is not a user-facing API, it shouldn't be a feature-type PR. I believe it should be changed to an optimize type instead. Could you also fix the codecov/patch issue by adding some test cases to increase coverage? Of course, you could also improve unit test coverage in a subsequent PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org
