funky-eyes commented on code in PR #7337:
URL: https://github.com/apache/incubator-seata/pull/7337#discussion_r2094530089


##########
core/src/main/java/org/apache/seata/core/rpc/netty/RmNettyRemotingClient.java:
##########
@@ -86,6 +86,24 @@ public void init() {
                 
getClientChannelManager().initReconnect(transactionServiceGroup, failFast);
             }
         }
+
+        registerChannelEventListener(new ChannelEventListener() {
+            @Override public void onChannelConnected(Channel channel) {
+                LOGGER.debug("Channel active: {}", channel.remoteAddress());

Review Comment:
   You should first check if the log level is set to debug before printing 
debug logs.



##########
core/src/main/java/org/apache/seata/core/rpc/netty/TmNettyRemotingClient.java:
##########
@@ -84,6 +84,24 @@ public void onChangeEvent(ConfigurationChangeEvent event) {
                 }
             }
         });
+
+        registerChannelEventListener(new ChannelEventListener() {
+            @Override public void onChannelConnected(Channel channel) {
+                LOGGER.debug("Channel active: {}", channel.remoteAddress());

Review Comment:
   You should first check if the log level is set to debug before printing 
debug logs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org

Reply via email to