funky-eyes commented on code in PR #7344: URL: https://github.com/apache/incubator-seata/pull/7344#discussion_r2095289440
########## server/src/main/java/org/apache/seata/server/session/GlobalSession.java: ########## @@ -682,29 +677,65 @@ public byte[] encode() { byteBuffer.putInt(0); } byteBuffer.putLong(beginTime); - byteBuffer.put((byte)status.getCode()); + byteBuffer.put((byte) status.getCode()); BufferUtils.flip(byteBuffer); byte[] result = new byte[byteBuffer.limit()]; byteBuffer.get(result); return result; } - private int calGlobalSessionSize(byte[] byApplicationIdBytes, byte[] byServiceGroupBytes, byte[] byTxNameBytes, - byte[] xidBytes, byte[] applicationDataBytes) { + public void checkSize() throws TransactionException { Review Comment: I believe the check methods of these two classes are not the same, because GlobalSession does not contain the lockKey property. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org