funky-eyes commented on PR #7344: URL: https://github.com/apache/incubator-seata/pull/7344#issuecomment-2891221408
> I’ve written one question above! > > Also, I think it would be great to add a unit test to verify that the `checkSize` method is called when in Raft mode. > > If that unit test is added, I believe a full integration test may not be strictly necessary. It's not possible to construct multiple Raft nodes to form a Raft cluster within unit tests. Therefore, I believe that calling the checkSize method in RaftSessionManager is not fundamentally different from directly calling the checkSize method of GlobalSession and BranchSession, unless we use integration tests instead of unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org
