funky-eyes commented on code in PR #7414:
URL: https://github.com/apache/incubator-seata/pull/7414#discussion_r2128966894


##########
core/src/main/java/org/apache/seata/core/rpc/netty/NettyClientBootstrap.java:
##########
@@ -70,7 +69,7 @@ public class NettyClientBootstrap implements 
RemotingBootstrap {
     private final NettyPoolKey.TransactionRole transactionRole;
     private final EventLoopGroup eventLoopGroupWorker;
 
-    private EventExecutorGroup defaultEventExecutorGroup;
+    private final EventExecutorGroup defaultEventExecutorGroup;

Review Comment:
   > > Was there any specific reason you decided not to remove 
`defaultEventExecutorGroup`?
   > 
   > Considering the limited understanding of the original design, we will 
adhere to the principle of minimal changes and prioritize resolving the 
resource consumption issue with the ​DefaultEventExecutorGroup. If there are no 
plans to enable this feature in the future, I could also consider removing it.
   
   I think it can be deleted now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org

Reply via email to