YongGoose commented on code in PR #7414:
URL: https://github.com/apache/incubator-seata/pull/7414#discussion_r2129030736
##########
core/src/main/java/org/apache/seata/core/rpc/netty/NettyClientBootstrap.java:
##########
@@ -70,7 +69,7 @@ public class NettyClientBootstrap implements
RemotingBootstrap {
private final NettyPoolKey.TransactionRole transactionRole;
private final EventLoopGroup eventLoopGroupWorker;
- private EventExecutorGroup defaultEventExecutorGroup;
+ private final EventExecutorGroup defaultEventExecutorGroup;
Review Comment:
+1
Since we’ve already confirmed in the issue that it’s no longer being used, I
believe it’s best to remove it!
Splitting the work into two steps introduces unnecessary process, in my
opinion.
Since both PMC members and committers will review the code and catch any
unexpected issues, I don’t think there’s any need to worry.
I believe this is the purpose of the code review process. 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
