simzyoo commented on code in PR #7480: URL: https://github.com/apache/incubator-seata/pull/7480#discussion_r2174593779
########## server/src/main/java/org/apache/seata/server/coordinator/DefaultCore.java: ########## @@ -486,7 +486,7 @@ public boolean doGlobalRollback(GlobalSession globalSession, boolean retrying) t String.valueOf(retrying), ex.getMessage() }); - if (!retrying) { + if (shouldQueueToRetryRollback(retrying, globalSession)) { Review Comment: > Why not directly remove this retrying check? Then handle the transaction state transition in the queueToRetryRollback method instead? Does it mean moving the logic of shouldQueueToRetryRollback(retrying, globalSession) into globalSession.queueToRetryRollback()? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org