funky-eyes commented on code in PR #7480:
URL: https://github.com/apache/incubator-seata/pull/7480#discussion_r2177698040
##########
server/src/main/java/org/apache/seata/server/coordinator/DefaultCore.java:
##########
@@ -486,7 +486,7 @@ public boolean doGlobalRollback(GlobalSession
globalSession, boolean retrying) t
String.valueOf(retrying),
ex.getMessage()
});
- if (!retrying) {
+ if (shouldQueueToRetryRollback(retrying,
globalSession)) {
Review Comment:
> > Why not directly remove this retrying check? Then handle the transaction
state transition in the queueToRetryRollback method instead?
>
> Does it mean moving the logic of shouldQueueToRetryRollback(retrying,
globalSession) into globalSession.queueToRetryRollback()?
Yes, because regardless of whether it is in a retry state or not, the
transaction always transitions from state A to a substate of A, such as
Committing. If the transaction in this state fails, the state will change to
CommitRetry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
