YongGoose commented on code in PR #7570:
URL: https://github.com/apache/incubator-seata/pull/7570#discussion_r2253269465
##########
integration-tx-api/src/main/java/org/apache/seata/integration/tx/api/interceptor/handler/AbstractProxyInvocationHandler.java:
##########
Review Comment:
Is there a specific reason why `order` method wasn’t implemented in
`AbstractProxyInvocationHandler`?
IMO, Implementing `order` in `AbstractProxyInvocationHandler` would allow us
to take advantage of inheritance.
##########
integration-tx-api/src/main/java/org/apache/seata/integration/tx/api/interceptor/handler/AbstractProxyInvocationHandler.java:
##########
@@ -59,7 +59,7 @@ public void setOrder(int order) {
@Override
public int getOrder() {
- return this.order;
+ return this.order();
Review Comment:
Is there a reason why the `order` function needs to return?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
