keepConcentration commented on PR #7570:
URL: https://github.com/apache/incubator-seata/pull/7570#issuecomment-3155033210
Thank you for the review! Let me summarize the feedback as I understand it:
1. Implement the `order()` method in `AbstractProxyInvocationHandler`:
```java
@Override
public int order() {
return this.order;
}
```
2. Implement the `order()` method in `GlobalTransactionalInterceptorHandler`:
```java
@Override
public int order() {
return this.order;
}
```
→ With this, all classes implementing `ProxyInvocationHandler` will now
explicitly implement the `order()` method.
3. The `getOrder()` method in `AbstractProxyInvocationHandler` returns
`this.order`:
```java
@Override
public int getOrder() {
return this.order;
}
```
One thing I noticed is that both the `order()` and `getOrder()` methods in
`AbstractProxyInvocationHandler` now have the same implementation, which
results in a bit of duplication.
Please let me know if this approach looks good to you. I’ll proceed
accordingly once I hear back from you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
