funky-eyes commented on code in PR #7664:
URL: https://github.com/apache/incubator-seata/pull/7664#discussion_r2380778927
##########
sqlparser/seata-sqlparser-druid/src/test/java/org/apache/seata/sqlparser/druid/oracle/OracleInsertRecognizerTest.java:
##########
@@ -84,7 +84,7 @@ public void testGetInsertColumns() {
String s = "insert into t(a) values (?)";
List<SQLStatement> sqlStatements = SQLUtils.parseStatements(s,
DB_TYPE);
SQLInsertStatement sqlInsertStatement = (SQLInsertStatement)
sqlStatements.get(0);
- sqlInsertStatement.getColumns().add(new OracleBinaryDoubleExpr());
+ sqlInsertStatement.getColumns().add(new OracleIntervalExpr());
Review Comment:
Why was OracleBinaryDoubleExpr changed to OracleIntervalExpr? Is it because
newer versions of Druid return a different Expr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
