dsomehan commented on code in PR #7664:
URL: https://github.com/apache/incubator-seata/pull/7664#discussion_r2384422715
##########
sqlparser/seata-sqlparser-druid/src/test/java/org/apache/seata/sqlparser/druid/oracle/OracleInsertRecognizerTest.java:
##########
@@ -84,7 +84,7 @@ public void testGetInsertColumns() {
String s = "insert into t(a) values (?)";
List<SQLStatement> sqlStatements = SQLUtils.parseStatements(s,
DB_TYPE);
SQLInsertStatement sqlInsertStatement = (SQLInsertStatement)
sqlStatements.get(0);
- sqlInsertStatement.getColumns().add(new OracleBinaryDoubleExpr());
+ sqlInsertStatement.getColumns().add(new OracleIntervalExpr());
Review Comment:
因为 druid 1.2.25
修改了OracleBinaryDoubleExpr的继承路径，改为继承了SQLTypeExpr,导致在这个测试用例里无法抛出异常SQLParsingException，
我猜测这个测试用例编写目的是为了输入一个InsertRecognizer解析不了的类型，抛出异常
Because druid 1.2.25 changed the inheritance path of OracleBinaryDoubleExpr
to inherit from SQLTypeExpr, there is no way to throw a SQLParsingException in
this test case. My guess is that this test case is written to throw an
exception for input of a type that InsertRecognizer can't parse
https://github.com/alibaba/druid/pull/6367/files#diff-fcc11688728fe89390da42807576626d1b4c855875496dd996787932088e5173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
