XiaoyangCai360 opened a new pull request, #7859:
URL: https://github.com/apache/incubator-seata/pull/7859
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing
guidelines -->
- [x] I have read the
[CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md)
guidelines.
- [x] I have registered the PR
[changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
This PR resolves test flakiness in
`org.apache.seata.common.metadata.MetadataTest`, specifically:
- `MetadataTest.testToString`
- `MetadataTest.testIsRaftMode`
The flakiness was caused by:
1) the test class sharing a single static `Metadata` instance across tests,
making assertions dependent on test execution order (e.g., `storeMode` mutated
by other tests); and
2) `testToString` relying on an exact `toString()` output, which is brittle
because field/map ordering may vary across executions and under NonDex.
The fix makes the tests deterministic by setting up required state
explicitly and using order-independent assertions (instead of strict string
equality).
**This PR is test-only and does not modify production code.**
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes
#97. -->
### Ⅲ. Why don't you add test cases (unit test/integration test)?
This PR focuses on stabilizing existing unit tests by removing
order-dependent assumptions and brittle `toString()` comparisons.
### Ⅳ. Describe how to verify it
Run the affected tests repeatedly under a non-deterministic execution
environment such as [NonDex](https://github.com/TestingResearchIllinois/NonDex)
to confirm stability.
Example command:
```bash
mvn -pl common \
-am edu.illinois:nondex-maven-plugin:2.1.7:nondex \
-Dtest=org.apache.seata.common.metadata.MetadataTest \
-DnondexRuns=20 \
-DfailIfNoTests=false
```
### Ⅴ. Special notes for reviews
- Test-only change in the `common` module.
- No production code modified.
- Improves CI stability under non-deterministic execution orders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
