XiaoyangCai360 commented on PR #7859: URL: https://github.com/apache/incubator-seata/pull/7859#issuecomment-3658750971
Thanks for the questions and the suggestion! 1. There is no public CI failure record for these tests. The flakiness was identified using NonDex, which exposes non-deterministic behaviors such as shared static state and order-dependent assertions. Although this issue may not consistently surface in CI today, it represents a latent source of non-deterministic failures that can cause flaky CI behavior under different JVM implementations, execution orders, or future refactoring. 2. I agree that using @BeforeEach would also address the shared-state issue. However, in this PR, I took a minimal approach to make the affected tests self-contained by explicitly setting the required state (storeMode) and avoiding brittle, order-dependent toString() equality checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
