Code-Fight commented on code in PR #1031:
URL:
https://github.com/apache/incubator-seata-go/pull/1031#discussion_r2636931304
##########
pkg/remoting/config/config_test.go:
##########
@@ -161,64 +159,3 @@ func TestTransportConfig_RegisterFlagsWithPrefix(t
*testing.T) {
})
}
}
-
-func TestSeataConfig_InitAndGet(t *testing.T) {
Review Comment:
You removed the old unit test code, but did not add additional tests to
cover the newly added code. As a result, the current test coverage has
decreased and more unit tests need to be added.
##########
pkg/client/client.go:
##########
@@ -65,15 +64,12 @@ func initTmClient(cfg *Config) {
// initRemoting init rpc client
func initRemoting(cfg *Config) {
- seataConfig := remoteConfig.SeataConfig{
Review Comment:
I think we should keep a naming style similar to remoteConfig.SeataConfig,
rather than using getty.ClientIdentity.
Getty is not equivalent to remote — getty is just one implementation of
remote.
It can be understood as an abstraction, but the name itself could be changed
to something more elegant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
