Zhengcy05 opened a new pull request, #8201:
URL: https://github.com/apache/incubator-seata/pull/8201
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing
guidelines -->
- [x] I have read the
[[CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md)](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md)
guidelines.
- [x] I have registered the PR
[[changes](https://github.com/apache/incubator-seata/tree/2.x/changes)](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
This PR prevents the scheduled async-commit worker from modifying a
`GlobalSession` while the initial commit thread is still cleaning its file-mode
global locks.
- Execute scheduled async commits through `SessionHolder.lockAndExecute`.
- Recheck that the transaction is still `AsyncCommitting` after acquiring
the session lock.
- Add a concurrency regression test that verifies the async worker waits for
the initial cleanup to finish.
- Verify that the same global lock key can be acquired by a subsequent
transaction after the async commit completes.
### Ⅱ. Does this pull request fix one issue?
Fixes #8197.
### Ⅲ. Why don't you add test cases (unit test/integration test)?
A unit test has been added to reproduce the ordering between the initial
commit cleanup and the scheduled async-commit worker.
The test verifies that:
- The async worker attempts to acquire the same `GlobalSession` lock.
- The worker cannot remove branch sessions while the initial cleanup holds
the lock.
- The remaining global lock is released before async branch removal.
- A subsequent transaction can register the same lock key.
### Ⅳ. Describe how to verify it
- `mvn -pl server -am
"-Dtest=DefaultCoordinatorTest#handleAsyncCommittingWaitsForGlobalSessionLockTest"
-Dsurefire.failIfNoSpecifiedTests=false test`
- `mvn -pl server -am -Dtest=DefaultCoordinatorTest
-Dsurefire.failIfNoSpecifiedTests=false test`
The complete `DefaultCoordinatorTest` run passed with 52 tests, 0 failures,
0 errors, and 5 skipped. All 90 reactor modules completed successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
