funky-eyes commented on code in PR #8201:
URL: https://github.com/apache/incubator-seata/pull/8201#discussion_r3773411002
##########
server/src/main/java/org/apache/seata/server/coordinator/DefaultCoordinator.java:
##########
@@ -530,7 +530,12 @@ protected void handleAsyncCommitting() {
}
SessionHelper.forEach(asyncCommittingSessions, asyncCommittingSession
-> {
try {
- core.doGlobalCommit(asyncCommittingSession, true);
+ SessionHolder.lockAndExecute(asyncCommittingSession, () -> {
+ if
(!GlobalStatus.AsyncCommitting.equals(asyncCommittingSession.getStatus())) {
Review Comment:
Why do we need to add this status check? Aren’t the transactions entering
this task already queried based on their status?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
