tachibana22 opened a new pull request, #1152: URL: https://github.com/apache/incubator-seata-go/pull/1152
- [x] I have registered the PR [changes](https://github.com/apache/incubator-seata-go/tree/master/changes). **What this PR does**: - Migrates the SQL parser dependency from `[github.com/arana-db/parser](https://github.com/arana-db/parser)` to upstream `[github.com/pingcap/tidb/pkg/parser](https://github.com/pingcap/tidb/pkg/parser)` (Supersedes #1120). - Bumps minimum Go version from 1.20 to 1.25 as required by the upstream TiDB parser. - Decouples production code from `test_driver` package across `base_executor.go`, `basic_undo_log_builder.go`, and `parser_factory.go`, utilizing the `ast.ParamMarkerExpr` interface and AST offset sorting. - Aligns all 13 AST traversal node branches in `basic_undo_log_builder.go` with `base_executor.go` to eliminate parameter ordering and extraction discrepancies. - Optimizes `buildLockKey` in `select_for_update_executor.go` while preserving full compatibility with the Seata TC lock key protocol. - Fixes single-case ticker loop and syntax errors in `pkg/remoting/grpc/listener.go` to ensure Go 1.25 toolchain compliance. - Adds comprehensive parameter ordering equivalence test matrix and AST traversal unit tests. **Which issue(s) this PR fixes**: Fixes #1104 Supersedes #1120 **Special notes for your reviewer**: 1. **Toolchain & Scope**: Changes in `pkg/remoting/grpc/listener.go` are strictly mechanical syntax/linter fixes (`for range ticker.C`) required for `go build` and `golangci-lint` to pass cleanly under Go 1.25. 2. **`test_driver` Decoupling**: Direct references to `*test_driver.ParamMarkerExpr` in production code have been replaced with the `ast.ParamMarkerExpr` interface and reflection helpers. 3. **Equivalence & Coverage**: Parameter marker order equivalence tests (`TestAssignParamMarkerOrders_EquivalenceMatrix`) and builder tests have been added to prevent coverage regression. **Does this PR introduce a user-facing change?**: yes ```release-note action required: Bump minimum Go version from 1.20 to 1.25 (required by upstream `github.com/pingcap/tidb/pkg/parser`). All downstream users must upgrade to Go 1.25+. Replaced `github.com/arana-db/parser` with upstream TiDB parser. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
