github-actions[bot] commented on PR #1152:
URL:
https://github.com/apache/incubator-seata-go/pull/1152#issuecomment-5479826330
> Bot detected the issue body's language is not English, translate it
automatically.
# # # Detailed description of the change document
# # # # 1. Go 1.25 toolchain adapts to Linter
- * * `pkg/remoting/grpc/channel_manager.go` * *
- Replace the deprecated constant `reflect.Ptr` in the reflection judgment
with `reflect.Pointer` to eliminate the constant inline warning raised by
`govet' under Go 1.25.
- * * `pkg/datasource/sql/conn_at_test.go` * *
- Simplified `var primaryErr error = errors.New (name)` to `var primaryErr
= errors.New (name)`, eliminating redundant declaration blocking for rvalue
known types by the `staticcheck' ST1023 rule.
- * * `pkg/datasource/sql/datasource/datasource_manager.go` * *- Added a
`//nolint: staticcheck` annotation to the null logic of the return value of the
`GetResourceManager` interface to suppress the false positive of the
`staticcheck' SA4023 on the historical stock interface type and avoid
unnecessary intrusion into the underlying generic architecture.
- * *
`pkg/saga/statemachine/engine/config/default_statemachine_config.go`/`pkg/saga/statemachine/store/db/statelog.go`
* *
- Add the '//nolint: staticcheck` annotation above the `if mgr! = nil`
decision of the RM instance to the saga state machine to uniformly avoid SA4023
stock alarms.
# # # # 2. Undo Log Builder Single Test Structure Correction
- * * `pkg/datasource/sql/undo/builder/basic_undo_log_builder_test.go` * *-
In the `TestBasicUndoLogBuilder_BuildSelectArgs_ComplexAST` table-driven test
matrix, adjust the original `Subquery and Exists` to the `Parentheses and
Unary` use case (`select * from t where not (a =?) and (b =?)`).
- Overwrite and verify the new `UnaryOperationExpr` and `ParenthesesExpr`
branches in `traversalArgs` to ensure that the Undo Log build engine passes the
single test, and the whole warehouse unit test and Codecov coverage collection
process are completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
