terrymanu commented on a change in pull request #2949: 4.0.0-RC2 does not
support Oracle 12C connection configuration #2911
URL:
https://github.com/apache/incubator-shardingsphere/pull/2949#discussion_r319741265
##########
File path:
sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/datasource/dialect/OracleDataSourceMetaData.java
##########
@@ -40,16 +40,24 @@
private final int port;
private final String schemaName;
-
- private final Pattern pattern =
Pattern.compile("jdbc:oracle:(thin|oci|kprb):@(//)?([\\w\\-\\.]+):?([0-9]*)[:/]([\\w\\-]+)",
Pattern.CASE_INSENSITIVE);
-
+ //modify by chenty 20190823 to support oracle 12c config like
jdbc:oracle:thin:@127.0.0.1:11521/camp2.xxx.com
Review comment:
Please remove inline comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
