terrymanu commented on a change in pull request #2949: 4.0.0-RC2 does not
support Oracle 12C connection configuration #2911
URL:
https://github.com/apache/incubator-shardingsphere/pull/2949#discussion_r319741314
##########
File path:
sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/util/StringUtil.java
##########
@@ -67,4 +67,10 @@ public static boolean isLongValue(final String value) {
return false;
}
}
+
+ //modify by chenty 20190823
+ public static boolean isEmpty(String str) {
Review comment:
Can you make name of this method and parameter more make sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
