terrymanu commented on a change in pull request #3158: test added for package of org.apache.shardingsphere.core.optimize.segment.insert URL: https://github.com/apache/incubator-shardingsphere/pull/3158#discussion_r329442691
########## File path: sharding-core/sharding-core-preprocessor/src/main/java/org/apache/shardingsphere/core/optimize/segment/insert/expression/DerivedParameterMarkerExpressionSegment.java ########## @@ -28,6 +29,7 @@ */ @Getter @ToString(callSuper = true) +@EqualsAndHashCode Review comment: Why need @EqualsAndHashCode, does `DerivedParameterMarkerExpressionSegment ` add into Set or Map? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
