taojintianxia commented on code in PR #20169:
URL: https://github.com/apache/shardingsphere/pull/20169#discussion_r945311149
##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-env/src/test/java/org/apache/shardingsphere/test/integration/env/container/atomic/storage/config/impl/postgresql/PostgreSQLContainerConfigurationFactory.java:
##########
@@ -17,27 +17,37 @@
package
org.apache.shardingsphere.test.integration.env.container.atomic.storage.config.impl.postgresql;
-import
org.apache.shardingsphere.test.integration.env.container.atomic.storage.config.StorageContainerConfiguration;
-
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
import java.util.Collections;
import java.util.Map;
-public class DefaultPostgreSQLContainerConfiguration implements
StorageContainerConfiguration {
+/**
+ * PostgreSQL container configuration factory.
+ */
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
+public final class PostgreSQLContainerConfigurationFactory {
+
+ /**
+ * Create new instance of postgresql container configuration.
+ *
+ * @return created instance
+ */
+ public static PostgreSQLContainerConfiguration newInstance() {
+ return new PostgreSQLContainerConfiguration(getCommands(),
getContainerEnvs(), getMountedResources());
+ }
- @Override
- public String[] getCommands() {
+ private static String[] getCommands() {
String[] commands = new String[1];
commands[0] = "-c config_file=/etc/postgresql/postgresql.conf";
return commands;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
