taojintianxia commented on code in PR #20169: URL: https://github.com/apache/shardingsphere/pull/20169#discussion_r945311085
########## shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-env/src/test/java/org/apache/shardingsphere/test/integration/env/container/atomic/storage/config/impl/postgresql/PostgreSQLContainerConfiguration.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.test.integration.env.container.atomic.storage.config.impl.postgresql; + +import lombok.Getter; +import lombok.RequiredArgsConstructor; +import org.apache.shardingsphere.test.integration.env.container.atomic.storage.config.StorageContainerConfiguration; + +import java.util.Map; + +/** + * PostgreSQL container configuration. + */ +@Getter +@RequiredArgsConstructor +public final class PostgreSQLContainerConfiguration implements StorageContainerConfiguration { Review Comment: done ########## shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-env/src/test/java/org/apache/shardingsphere/test/integration/env/container/atomic/storage/config/impl/postgresql/PostgreSQLContainerConfigurationFactory.java: ########## @@ -17,27 +17,37 @@ package org.apache.shardingsphere.test.integration.env.container.atomic.storage.config.impl.postgresql; -import org.apache.shardingsphere.test.integration.env.container.atomic.storage.config.StorageContainerConfiguration; - +import lombok.AccessLevel; +import lombok.NoArgsConstructor; import java.util.Collections; import java.util.Map; -public class DefaultPostgreSQLContainerConfiguration implements StorageContainerConfiguration { +/** + * PostgreSQL container configuration factory. + */ +@NoArgsConstructor(access = AccessLevel.PRIVATE) +public final class PostgreSQLContainerConfigurationFactory { + + /** + * Create new instance of postgresql container configuration. + * + * @return created instance + */ + public static PostgreSQLContainerConfiguration newInstance() { + return new PostgreSQLContainerConfiguration(getCommands(), getContainerEnvs(), getMountedResources()); + } - @Override - public String[] getCommands() { + private static String[] getCommands() { String[] commands = new String[1]; commands[0] = "-c config_file=/etc/postgresql/postgresql.conf"; return commands; } - @Override - public Map<String, String> getEnvs() { + private static Map<String, String> getContainerEnvs() { Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
