zhfeng opened a new pull request, #23550: URL: https://github.com/apache/shardingsphere/pull/23550
It sould be helpful to fix https://github.com/apache/shardingsphere/issues/19990 Changes proposed in this pull request: - Force to use `JDK 11` above to build shardingsphere - We still run all the e2e tests on `JDK 8` to make sure there is no compatitable issues. - https://github.com/apache/shardingsphere/issues/19990 which needs to run `antlr-maven-plugin` to generate the parser classes. The antlr Tool are only for `JDK 11` after upgrading to 4.10.1. So if upgrading `antlr`, it will force user to build shardingsphere with `JDK 11` It seems that we need to support `JDK 8` for a long time. There is no such plan to drop it, see the relevant discussion https://lists.apache.org/thread/kgtfx5vnw73o61lkvdshyfvjfvvzk3js Before committing this PR, I'm sure that I have checked the following options: - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project. - [ ] I have self-reviewed the commit code. - [ ] I have (or in comment I request) added corresponding labels for the pull request. - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`. - [ ] I have made corresponding changes to the documentation. - [ ] I have added corresponding unit tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
