zhfeng commented on code in PR #23550:
URL: https://github.com/apache/shardingsphere/pull/23550#discussion_r1070910013
##########
pom.xml:
##########
@@ -944,7 +944,7 @@
<version>${maven.version.range}</version>
</requireMavenVersion>
<requireJavaVersion>
- <version>${java.version}</version>
+ <version>11</version>
Review Comment:
Yeah, we can. But It cuould confuse people that building with Java 8 will
fail after upgrading antlr to 4.10.1. Anyway, we need to add a NOTE in README
to mention that `Building from source` of shardingsphere must use `JDK 11`
above. @terrymanu WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
