sandynz commented on code in PR #23838:
URL: https://github.com/apache/shardingsphere/pull/23838#discussion_r1090442007
##########
test/e2e/pipeline/src/test/java/org/apache/shardingsphere/test/e2e/data/pipeline/cases/base/PipelineBaseE2EIT.java:
##########
@@ -124,12 +124,19 @@ public PipelineBaseE2EIT(final PipelineTestParameter
testParam) {
}
createProxyDatabase(testParam.getDatabaseType());
if (PipelineEnvTypeEnum.NATIVE == ENV.getItEnvType()) {
+ try {
+ cleanUpPipelineJobs();
+ } catch (final SQLException ex) {
+ throw new RuntimeException(ex);
+ }
cleanUpDataSource();
}
extraSQLCommand =
JAXB.unmarshal(Objects.requireNonNull(PipelineBaseE2EIT.class.getClassLoader().getResource(testParam.getScenario())),
ExtraSQLCommand.class);
pipelineWatcher = new PipelineWatcher(containerComposer);
}
+ protected abstract void cleanUpPipelineJobs() throws SQLException;
Review Comment:
1, Could we remove this `protected abstract void cleanUpPipelineJobs` method.
2, Add `protected void cleanUpPipelineJobs` impl here, transfer rollback and
commit SQL in parameters;
then `AbstractMigrationE2EIT` add new method to invoke
`cleanUpPipelineJobs`, e.g. `cleanUpMigrationJobs`,
and sub-classes could just invoke `cleanUpMigrationJobs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
