sandynz commented on code in PR #23838:
URL: https://github.com/apache/shardingsphere/pull/23838#discussion_r1091381568
##########
test/e2e/pipeline/src/test/java/org/apache/shardingsphere/test/e2e/data/pipeline/cases/base/PipelineBaseE2EIT.java:
##########
@@ -130,6 +131,27 @@ public PipelineBaseE2EIT(final PipelineTestParameter
testParam) {
pipelineWatcher = new PipelineWatcher(containerComposer);
}
Review Comment:
1, `cleanUpDataSource` should be invoked in every unit test method.
2, NATIVE env type could be embed in `cleanUpDataSource`.
##########
test/e2e/pipeline/src/test/java/org/apache/shardingsphere/test/e2e/data/pipeline/cases/base/PipelineBaseE2EIT.java:
##########
@@ -130,6 +131,27 @@ public PipelineBaseE2EIT(final PipelineTestParameter
testParam) {
pipelineWatcher = new PipelineWatcher(containerComposer);
}
Review Comment:
Could we add a new cleanUp method to combine `cleanUpPipelineJobs`,
`createProxyDatabase` and `cleanUpDataSource` together to simplify invocation?
##########
test/e2e/pipeline/src/test/java/org/apache/shardingsphere/test/e2e/data/pipeline/cases/base/PipelineBaseE2EIT.java:
##########
@@ -130,6 +131,27 @@ public PipelineBaseE2EIT(final PipelineTestParameter
testParam) {
pipelineWatcher = new PipelineWatcher(containerComposer);
}
Review Comment:
1, `createProxyDatabase` should be invoked after `cleanUpPipelineJobs`,
since `DROP DATABASE` might check uncompleted jobs.
2, `createProxyDatabase` should be invoked in every unit test method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
