zhfeng opened a new pull request, #23937:
URL: https://github.com/apache/shardingsphere/pull/23937

   Fixes #19990.
   
   Changes proposed in this pull request:
     - Bump antlr4 to 4.10.1
     - Only run `antlr4-maven-plugin` in JDK 11
     - Add generated sources in JDK 8
     - After merging this PR, we should clarify on docs and wiki that it needs 
to use **JDK 11** to build sources at first as it can generate codes for the g4 
parseres.
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following 
options:
   - [ x My code follows the [code of 
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) 
of this project.
   - [x] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the 
pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C 
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to