TeslaCN commented on PR #23937: URL: https://github.com/apache/shardingsphere/pull/23937#issuecomment-1415671651
> Sorry for the inconvenience. I took these changes because it could build with `JDK 11` to generate the parser codes only once, and `mvn clean install` could work with `JDK 8`. Ony when you change `g4` files, you have to re-generate these codes by `JDK 11`. I suppose that this could less impact on the developers with `JDK 8`. > > The for IDEA, I think you have to add source directory manually. such as `src/main/generated`. Do you have any other thought? I don't think manually add source directory is acceptable. Because we need to add 15 modules manually to start Proxy in IDEA, and these settings might be lost after doing some operation. I will raise a PR to restore the path of generated codes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
