strongduanmu commented on PR #25049: URL: https://github.com/apache/shardingsphere/pull/25049#issuecomment-1506425556
> ``` > SQL Case ID : insert_with_batch_and_composite_expression > SQL : INSERT INTO t_order (order_id, user_id, status) VALUES (?, ?, SUBSTR(?, 1)), (?, ?, SUBSTR(?, 1)) > SQL Params : [1, 1, 'init', 2, 2, 'init'] > > Parameter markers count assertion error: > > Expected: is <6> > but: was <8> > ``` > > Obviously, your transformation results in duplicate parameter counts, and you can choose to remove the calculateParameterCount call from the corresponding visit method. Hi @kanha-gupta, I take a look at this exception, you need to modify expected file for insert_with_batch_and_composite_expression case. Since you changed the parsing logic of SUBSTR, you need to change the expected file for all SQL cases that contain SUBSTR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
