strongduanmu commented on code in PR #26332:
URL: https://github.com/apache/shardingsphere/pull/26332#discussion_r1255640939
##########
parser/sql/dialect/mysql/src/main/antlr4/imports/mysql/Keyword.g4:
##########
@@ -108,14 +108,58 @@ AUTOCOMMIT
: A U T O C O M M I T
;
-INNODB
- : 'INNODB'
- ;
-
REDO_LOG
: 'REDO_LOG'
;
DELIMITER
: D E L I M I T E R
;
+
+ARCHIVE
+ : A R C H I V E
+ ;
+
+BLACKHOLE
+ : B L A C K H O L E
+ ;
+
+CSV
+ : C S V
+ ;
+
+FEDERATED
+ : F E D E R A T E D
+ ;
+
+INNODB
+ : I N N O D B
+ ;
+
+MEMORY
+ : M E M O R Y
+ ;
+
+MRG_MYISAM
+ : M R G UL_ M Y I S A M
+ ;
+
+MYISAM
+ : M Y I S A M
+ ;
+
+NDB
+ : N D B
+ ;
+
+NDBCLUSTER
+ : N D B C L U S T E R
+ ;
+
+PERFORMANCE_SCHEMA
+ : P E R F O R M A N C E UL_ S C H E M A
+ ;
+
+TOKUDB
+ : T O K U D B
+ ;
Review Comment:
Please add new line at the end of file.
##########
parser/sql/dialect/mysql/src/test/java/org/apache/shardingsphere/sql/parser/mysql/visitor/format/MySQLFormatVisitorIT.java:
##########
@@ -76,23 +76,23 @@ public Stream<? extends Arguments> provideArguments(final
ExtensionContext exten
+ "`runoob_test` NATIONAL CHAR(40),\n"
+ "`submission_date` DATE,\n"
+ "PRIMARY KEY (`runoob_id`)\n"
- + ")ENGINE=InnoDB DEFAULT CHARSET=utf8;",
+ + ")ENGINE=INNODB DEFAULT CHARSET=utf8;",
Review Comment:
Why modify InnoDB to INNODB?
##########
parser/sql/dialect/mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/type/MySQLDDLStatementVisitor.java:
##########
@@ -260,6 +262,13 @@ public ASTNode visitCreateTable(final CreateTableContext
ctx) {
if (null != ctx.createLikeClause()) {
result.setLikeTable((SimpleTableSegment)
visit(ctx.createLikeClause()));
}
+ if (null != ctx.createTableOptions()) {
+ for (CreateTableOptionContext each :
ctx.createTableOptions().createTableOption()) {
Review Comment:
Can you use visit call to reduce code level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
